D18938: Show assigned shortcut in drawer action delegates

[Marco Martin]

mart requested changes to this revision.
mart added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> GlobalDrawerActionItem.qml:102
> +        Layout.alignment: Qt.AlignVCenter | Qt.AlignRight
> +        visible: modelData.__shortcut.enabled && !Settings.tabletMode
> +        color: Theme.disabledTextColor

adding also && root.modal should fix the discover and other always-showing-sidebar apps use case.

Pretty sure the label will break on collapsed mode.
did you try on kirigami gallery to set the sidebar to collapsible with this patch on?

should probably be

visible: modelData.__shortcut.enabled && !Settings.tabletMode && root.modal && !root.collapsible

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D18938

To: hein, mart, apol
Cc: ngraham, plasma-devel, #plasma, dkardarakos, apol, davidedmundson, mart, hein
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190218/b55024ae/attachment-0001.html>