D19036: [notifications] Lift up notification content if one line of body text droops

[Anthony Fieroni]

anthonyfieroni added inline comments.

INLINE COMMENTS

> NotificationItem.qml:34-47
> +        if (bodyText.lineCount > 1) {
> +            return mainLayout.height
> +        } else {
> +            if (appIconItem.valid || imageItem.nativeWidth > 0) {
> +                return Math.max((mainLayout.height + 1.5 * units.smallSpacing),(units.iconSizes.large + 2 * units.smallSpacing))
> +            } else {
> +                if (bottomPart.height != 0) {

When you have return you don't need else branch

  if (bodyText.lineCount > 1) {
      return mainLayout.height
  }
  if (appIconItem.valid || imageItem.nativeWidth > 0) {
      return Math.max((mainLayout.height + 1.5 * units.smallSpacing),(units.iconSizes.large + 2 * units.smallSpacing))
  }
  and so on

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19036

To: rooty, #plasma, #vdg, broulik, ngraham
Cc: anthonyfieroni, filipf, ngraham, abetts, broulik, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190216/ec2dba0b/attachment-0001.html>