D19036: [notifications] Lift up notification content if one line of body text droops (improve padding)
Krešimir Čohar
noreply at phabricator.kde.org
Fri Feb 15 14:00:57 GMT 2019
rooty created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
rooty requested review of this revision.
REVISION SUMMARY
This patch lifts up the text content of notifications in which the combination of a single line of body text and its heading are taller than their icon and thereby prevents the notification content from drooping too far down and having too much of a bottom margin if it should become much larger than the icon. Seeing as the icon and its margins are never going to be taller than the content in question, and the icon is always going to have 1 units.smallSpacing above it, this patch adjusts the height accordingly (0.5 unit of smallSpacing above + 0.5 for the spacing below the heading + 0.5 below the content, accommodating the text) to achieve more even padding.
REPOSITORY
R120 Plasma Workspace
BRANCH
lift-up-noto (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D19036
AFFECTED FILES
applets/notifications/package/contents/ui/NotificationItem.qml
To: rooty
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190215/1633104a/attachment.html>
More information about the Plasma-devel
mailing list