D19033: [about-distro] run absolute paths through qicon intead of qpixmap

[Harald Sitter]

sitter created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
sitter requested review of this revision.

REVISION SUMMARY
  qicon::fromtheme internally skips resolution of absolute paths and instead
  simply opens it by path. so, simplify the code by only calling fromTheme.
  
  this has two additional advantages:
  a) the icon size is now always capped at 128x128 (smaller icons are smaller
  
    but that beats upscaling) preventing problems where a distribution might
    use too large a resolution so the kcm looks wonky on scaling factor 1
  
  b) the LogoPath config may now also be an icon name for resolution through
  
    the icon theme instead of an absolute path

TEST PLAN
  - huge logos are scaled into shape

REPOSITORY
  R102 KInfoCenter

BRANCH
  Plasma/5.15

REVISION DETAIL
  https://phabricator.kde.org/D19033

AFFECTED FILES
  Modules/about-distro/README
  Modules/about-distro/src/Module.cpp

To: sitter
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190215/4fb7b4ad/attachment.html>