D19021: [Digital Clock] Fix 24h tri-state button broken in port to QQC2

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  +1 for fixing the bug, but this should really have a better UI. Using a checkbox for more something that has more than just binary on/off states is a poor practice because it's never apparent what the third "half checked" state actually means. We should more towards turning this into a combobox or radio buttons with the options  "System locale default", "Force 12 hour", and "Force 24 hour" (or something like that).

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19021

To: Zren, #plasma, ngraham
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190214/571fd5ef/attachment.html>