D18716: Add a TextField component

[Marco Martin]

mart added a comment.


  also, the name should possibily not conflict with QQC2 TextField, like ActionTextField or something like that.

INLINE COMMENTS

> TextField.qml:21
> +import QtQuick 2.5
> +import QtQuick.Controls 2.1
> +import org.kde.kirigami 2.4 as Kirigami

always namespace the controls import as
import QtQuick.Controls 2.1 as Controls

> TextField.qml:89
> +    ToolTip {
> +        delay: Kirigami.Units.longDuration
> +        visible: root.focusSequence != null && root.focusSequence.hovered

the style already sets the correct values for duration and timeout, this line should be removed

> TextField.qml:106
> +
> +    ToolButton {
> +        anchors {

text will go under both buttons, in order to avoid that, probably anchors should be added to the TextField's contentItem to make space for the buttons.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D18716

To: ognarb, apol, #kirigami, ngraham, mart
Cc: broulik, mart, apol, ngraham, plasma-devel, dkardarakos, davidedmundson, hein
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190214/52456784/attachment.html>