D18939: KMenuEdit: add search/filter bar

Nathaniel Graham noreply at phabricator.kde.org
Wed Feb 13 02:51:30 GMT 2019


ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Excellent. UX and code look good to me now. @cfeck, or #plasma <https://phabricator.kde.org/tag/plasma/> folks, any comments or shall we land this?
  
  BTW @tuxxi you'll need to fix your git authorship information to use your full name. If I try to land this now, the commit hookscript will complain that `tuxxi <aidan.sojourner at gmail.com>` isn't valis because the name part doesn't have a last name. Assuming your email address reveals your real name, I can fix this up for you before it lands, but it would be nice not to have to in the future, ya know? :-)
  
  See https://community.kde.org/Get_Involved/development#Configure_Git

REPOSITORY
  R103 KMenu Editor

BRANCH
  search-bar

REVISION DETAIL
  https://phabricator.kde.org/D18939

To: tuxxi, ngraham, #plasma, cfeck
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190213/7c72344d/attachment.html>


More information about the Plasma-devel mailing list