D18918: Make the text of "View Settings" action more specific

Michail Vourlakos noreply at phabricator.kde.org
Tue Feb 12 12:08:52 GMT 2019


mvourlakos added a comment.


  for Latte panels after startup or after switching layouts if the user right clicks the panel the menu is appearing correctly as:
  
  **Panel Setings...** ?

INLINE COMMENTS

> menu.cpp:92
> +    connect(this->containment(), &Plasma::Containment::userConfiguringChanged, this, [&](bool configuring){
> +                m_configureAction->setVisible(!configuring);
> +                if (!configuring) setConfigureActionText();

why this is needed?

> menu.cpp:93
> +                m_configureAction->setVisible(!configuring);
> +                if (!configuring) setConfigureActionText();
> +    });

style issue. even for single lines ifs

  if (..) {
  
  }

REPOSITORY
  R878 Latte Dock

REVISION DETAIL
  https://phabricator.kde.org/D18918

To: trmdi, mvourlakos
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190212/b5dc66c7/attachment.html>


More information about the Plasma-devel mailing list