D18934: WIP: [Notifications] Remove close button border by porting to IconItem

[Filip Fila]

filipf created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
filipf requested review of this revision.

REVISION SUMMARY
  This patch ports the close button from a PlasmaComponents.Button to an IconItem so as to:
  
  1. achieve better visuals -> the close button frame is ugly
  2. achieve better symmetry -> the frame makes the close button appear indented
  3. achieve cohesion with ToolTipInstance.qml ->  also uses an IconItem for its close button
  
  To do/Dilemmas:
  
  - adjust symmetry issues caused by the port
  - port the Configure button as well?
  - add a fallback hover-aware circle for 3rd party themes whose "window-close" icons have no built-in hover effects?

REPOSITORY
  R120 Plasma Workspace

BRANCH
  port-notification-close-button (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18934

AFFECTED FILES
  applets/notifications/package/contents/ui/NotificationItem.qml

To: filipf
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190211/0e940657/attachment.html>