D18809: Image Wallpaper Slideshow - display the list of images that will be shown

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> image.h:184-185
>          int m_currentSlide;
>          BackgroundListModel *m_model;
> +        SlideModel* m_slideshowModel;
>          QFileDialog *m_dialog;

Why do we need two instances?

> slidemodel.cpp:30
> +{
> +    if (token != m_findToken) {
> +        return;

If you hit removeDir twice in quick succession we want it to remove both dirs

I dont' think we want the token for removal

> slidemodel.h:4
> +
> +#endif
> +

this needs to be at the end of the file

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D18809

To: davidre, #vdg, ngraham
Cc: alexde, davidedmundson, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190211/8e16b365/attachment.html>