D18908: [SwipeListItem] Use a real toolbutton to improve usability

[Aleix Pol Gonzalez]

apol added a comment.


  Overall +1

INLINE COMMENTS

> SwipeListItem.qml:264
>                      }
> -                    MouseArea {
> -                        id: actionMouse
> -                        anchors {
> -                            fill: parent;
> -                            margins: Settings.tabletMode ? -Units.smallSpacing : 0;
> +                    hoverEnabled: Settings.tabletMode ? undefined : true
> +                    Controls.ToolTip.delay: 1000

This undefined will just warn on tablet mode. I'd remove it, do we need to specify it? A ToolButton should already behave properly.

> SwipeListItem.qml:265
> +                    hoverEnabled: Settings.tabletMode ? undefined : true
> +                    Controls.ToolTip.delay: 1000
> +                    Controls.ToolTip.timeout: 5000

Should move these values to Units, can be done in a separate patch.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D18908

To: ngraham, mart, #kirigami
Cc: apol, plasma-devel, dkardarakos, davidedmundson, mart, hein
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190210/7dda2589/attachment.html>