D18848: [Kickoff] Return Kickoff to Favorites page after running a search and closing it

[Eike Hein]

hein added a comment.


  In D18848#407843 <https://phabricator.kde.org/D18848#407843>, @rooty wrote:
  
  > In D18848#407838 <https://phabricator.kde.org/D18848#407838>, @hein wrote:
  >
  > > This is a good change, but it's more worth finding out why it doesn't work already. Looking at the code, when `KickoffItem` is triggered it runs the `switchToInitial()` function in FullRepresentation.qml, which already switches tabs and is also what sets the state back to `Normal`. So setting the tab in the state shouldn't be necessary. Can you debug why setting `currentTab` in `switchToInitial()` apparently doesn't work?
  >
  >
  > I think it might be because of the switch from the state "Search" to the state "Normal", because this doesn't happen if the arrow keys are used to navigate to the right of Favorites, only when Search is invoked. There's a "currentTab: searchPage" (line 738) setting in the state "Search" that probably gets stuck. I didn't want to deal with changing "Search" because in my experience, Kickoff's search view can be pretty temperamental. This seemed like the safest course of action.
  
  
  Doesn't that mean the code in switchToInitial just needs reordering to set the state (to Normal) first and then do the tab change? (Or alternatively the tab change could be cleaned away from the function.)

REPOSITORY
  R119 Plasma Desktop

BRANCH
  fix-kickoff-initial-aftersearch (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18848

To: rooty, #vdg, #plasma, ngraham
Cc: ngraham, hein, filipf, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190208/9917bb95/attachment-0001.html>