D17796: Show accurate checked state for system monitor configuration pages
Kai Uwe Broulik
noreply at phabricator.kde.org
Fri Feb 8 09:04:40 GMT 2019
broulik added a comment.
> The call on line 141 looks superfluous - if there's any change to checked we modify cfg_sources which should trigger the reload.
QML cannot detect changes within a JS structure, if you `push()` into an `Array` or modify members of an `Object` it doesn't see the change and the automatism for `onCfg_...Changed` doesn't trigger
REVISION DETAIL
https://phabricator.kde.org/D17796
To: pavelmos, jriddell, #plasma, ngraham
Cc: broulik, davidedmundson, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190208/ac49a154/attachment.html>
More information about the Plasma-devel
mailing list