D18809: Image Wallpaper Slideshow - display the list of images that will be shown

David Redondo noreply at phabricator.kde.org
Thu Feb 7 17:20:57 GMT 2019


davidre added a comment.


  In D18809#407144 <https://phabricator.kde.org/D18809#407144>, @ngraham wrote:
  
  > This looks great!
  >
  > I would recommend removing the checkbox feature for now, since that's really a separate thing from the UI overhaul. Then we can get the UI overhaul in first and work on the checkbox part after that. Does that sound like a plan?
  
  
  Sounds like a good plan!

INLINE COMMENTS

> davidedmundson wrote in image.cpp:909
> You update m_uncheckedSlides  but you're not updating m_slideshowBackgrounds so it does nothing till you restart

Thanks for spotting this, will try testing this.

REVISION DETAIL
  https://phabricator.kde.org/D18809

To: davidre, #vdg
Cc: davidedmundson, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190207/e634e195/attachment.html>


More information about the Plasma-devel mailing list