D18646: [Colors KCM] Add search and filter

Kai Uwe Broulik noreply at phabricator.kde.org
Thu Feb 7 12:47:06 GMT 2019


broulik added inline comments.

INLINE COMMENTS

> davidedmundson wrote in main.qml:129
> why do we need a different approach from the way you've done the clear button?

If I could change the left padding of the `ComboBox` button I would have done that and placed an icon ontop. However, since it's all painted as a monolith by `KQuickStyleItem` I cannot.

It doesn't follow the `padding` properties because it's all derived from the `QStyle`, and changing that opens a can of worm imho.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D18646

To: broulik, #plasma, #vdg
Cc: davidedmundson, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190207/ac8d74da/attachment.html>


More information about the Plasma-devel mailing list