D18796: [PassiveNotification] Don't start timer until window has focus
Nathaniel Graham
noreply at phabricator.kde.org
Wed Feb 6 21:12:23 GMT 2019
ngraham created this revision.
ngraham added reviewers: Kirigami, mart, broulik, apol.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.
REVISION SUMMARY
WIth this patch, the `PassiveNotification`'s timer only starts when its parent window
has focus. This is important on the desktop where it's common to work with multiple
windows at a time, and otherwise these notifications are very easy to miss, especially
when their parent window is minimized or behind another window.
BUG: 403809
FIXED-IN: 5.56
Thanks to @broulik for the patch!
TEST PLAN
Open Discover, navigate to Source page, try to remove a Flatpak repo, then cancel the
password prompt and immediately sewitch to another window before the notification fires.
It will sit there on the window as long as it's inactive, and only disappear a few
seconds after the window gets focus.
REPOSITORY
R169 Kirigami
BRANCH
dont-start-passivenotification-timer-until-window-has-focus (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D18796
AFFECTED FILES
src/controls/templates/private/PassiveNotification.qml
To: ngraham, #kirigami, mart, broulik, apol
Cc: plasma-devel, broulik, dkardarakos, apol, davidedmundson, mart, hein
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190206/2b3a1a26/attachment.html>
More information about the Plasma-devel
mailing list