D18760: Don't accept invalid KNS EntryInternal results
Aleix Pol Gonzalez
noreply at phabricator.kde.org
Tue Feb 5 16:26:37 GMT 2019
apol requested changes to this revision.
apol added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> KNSBackend.cpp:213
> + const auto filtered = kFilter<KNSCore::EntryInternal::List>(entries, [this](const KNSCore::EntryInternal& entry){ return entry.isValid(); });
> const auto resources = kTransform<QVector<AbstractResource*>>(entries, [this](const KNSCore::EntryInternal& entry){ return resourceForEntry(entry); });
> if (!resources.isEmpty()) {
first arg should be `filtered`.
REPOSITORY
R134 Discover Software Store
REVISION DETAIL
https://phabricator.kde.org/D18760
To: leinir, apol, ngraham, #discover_software_store
Cc: plasma-devel, jraleigh, bam, GB_2, ragreen, ixoos, Pitel, ZrenBot, James, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190205/b9e1df25/attachment.html>
More information about the Plasma-devel
mailing list