D18632: Port away from deprecated KIO::UDSEntry::insert()
Friedrich W. H. Kossebau
noreply at phabricator.kde.org
Tue Feb 5 15:57:29 GMT 2019
kossebau added inline comments.
INLINE COMMENTS
> chinmoyr wrote in kio_desktop.cpp:183
> A doubt, why are you using replace here? Is UDS_TARGET_URL set somewhere before coming here?
:)
Well, I would rather be safe then sorry. We have no control over what other code might do to the entry object, also is there nothing noted in any API contracts.
And it's not very performance critical code here, so I propose future-proof code for now.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D18632
To: kossebau, #plasma
Cc: chinmoyr, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190205/4267bbaf/attachment.html>
More information about the Plasma-devel
mailing list