D18632: Port away from deprecated KIO::UDSEntry::insert()

Chinmoy Ranjan Pradhan noreply at phabricator.kde.org
Tue Feb 5 15:46:27 GMT 2019


chinmoyr added inline comments.

INLINE COMMENTS

> kio_desktop.cpp:183
>      QUrl localUrl(QUrl::fromLocalFile(entry.stringValue(KIO::UDSEntry::UDS_LOCAL_PATH)));
> -    entry.insert(KIO::UDSEntry::UDS_TARGET_URL, localUrl.toString());
> +    entry.replace(KIO::UDSEntry::UDS_TARGET_URL, localUrl.toString());
>  }

A doubt, why are you using replace here? Is UDS_TARGET_URL set somewhere before coming here?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D18632

To: kossebau, #plasma
Cc: chinmoyr, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190205/db1e3d75/attachment.html>


More information about the Plasma-devel mailing list