D18754: [Look and Feel KCM] Write schemeName last

Kai Uwe Broulik noreply at phabricator.kde.org
Tue Feb 5 11:13:26 GMT 2019


broulik created this revision.
broulik added reviewers: Plasma, davidedmundson.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  We copy the `.colors` file's contents into `kdeglobals` and I have seen many of them containing bogus
  
    [General]
    ColorScheme=Some Other Scheme
  
  which makes no sense. Ensure the `ColorScheme` that ends up in `kdeglobals` is the scheme defined by the look and feel package.
  
  BUG: 403774

TEST PLAN
  Downloaded "Modern" lnf from kde store, applied it and system changed to a dark color scheme.
  Previously it would write "Breeze Dark" from its colors file to kdeglobals, now it is correctly "BreezeDarcBlue"
  This also obsoletes D18752 <https://phabricator.kde.org/D18752> as now the correct scheme name is always present in kdeglobals

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D18754

AFFECTED FILES
  kcms/lookandfeel/kcm.cpp

To: broulik, #plasma, davidedmundson
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190205/ee786db7/attachment.html>


More information about the Plasma-devel mailing list