D18689: plasma-nm Connection Icon not showing correct icon when using a bridge

Jan Grulich noreply at phabricator.kde.org
Tue Feb 5 07:06:57 GMT 2019


jgrulich accepted this revision.
jgrulich added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> uiutils.h:126
> +     */
> +    static bool isConnectionTypeVirtual(NetworkManager::ConnectionSettings::ConnectionType type);
> +

Can you just move this method up under the isConnectionTypeSupported() method? So similar methods are together.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D18689

To: rthomas, jgrulich, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190205/8dbc83eb/attachment-0001.html>


More information about the Plasma-devel mailing list