D18654: [fonts:/ KIO] Implement stat() call

Kai Uwe Broulik noreply at phabricator.kde.org
Fri Feb 1 21:08:26 GMT 2019


broulik created this revision.
broulik added reviewers: Plasma, dfaure.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Needed for thumbnailer to work.
  
  BUG: 234754
  FIXED-IN: 5.16.0

TEST PLAN
  Depends on D18653 <https://phabricator.kde.org/D18653>
  Basically just moved the special case from `get` to `stat`, keeping the coding style. Possible that I now create a temporary file instead since the thumbnailer will still `get` and now hit the path where it generates a ZIP that cannot be previewed. Probably needs some rethinking but I don't want to open Pandora's box by poking this stuff too hard :)
  
  I now get thumbnails in `fonts:/` "folder". Opening fonts is still not possible, gives a different error now, but no regression there..

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D18654

AFFECTED FILES
  kcms/kfontinst/kio/KioFonts.cpp
  kcms/kfontinst/kio/KioFonts.h

To: broulik, #plasma, dfaure
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190201/3ebaceaf/attachment.html>


More information about the Plasma-devel mailing list