D18182: Fix new file creation leading to dupe items on a fresh view

Oleg Solovyov noreply at phabricator.kde.org
Fri Feb 1 11:17:24 GMT 2019


McPain added inline comments.

INLINE COMMENTS

> davidedmundson wrote in foldermodel.cpp:170
> Also I don't think I understand this:
> 
> - Delay this via queued connection, such that the row is available and can be mapped
> 
> at the point of rowsInserted() the row should be available, If not we have a source model bug.

like I said, in https://phabricator.kde.org/R119:cc9c3d32a381980e367aa893c6796d611c7a33a7 the Qt::QueuedConnection was removed from connection, but the comment was unchanged

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D18182

To: hein, #plasma, McPain, davidedmundson
Cc: ngraham, davidedmundson, fvogt, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190201/6a556896/attachment.html>


More information about the Plasma-devel mailing list