D26323: [KCM/Component] Terminal port to KConfigXT, make isDefault work

[Kevin Ottens]

ervin accepted this revision.
ervin added a comment.
This revision is now accepted and ready to land.


  One nitpick to address before pushing.
  
  Also I mark those accepted assuming there will be another phase where the settings objects will actually be properly matched to the GUI. Currently it's all fixing the isDefaults by hand based on GUI state but not on config state, also I don't think it currently honors the mutability state of those keys. This will need being addressed in further commits.

INLINE COMMENTS

> componentchooserterminal.cpp:67
>  
>  void CfgTerminalEmulator::load(KConfig *) {
> +	TerminalSettings settings;

I'd use the opportunity to fix that opening curly brace to have it on its own line

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26323

To: meven, ervin, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20191231/b4f2035c/attachment.html>