D26295: [KCM/Datetime] Convert a foreach, port away from KStandardDirs

Kevin Ottens noreply at phabricator.kde.org
Tue Dec 31 08:58:46 GMT 2019


ervin accepted this revision.
ervin added inline comments.

INLINE COMMENTS

> dtime.cpp:165
> +  for (const QString &possible_ntputility : possible_ntputilities) {
> +    auto ntpUtility = QStandardPaths::findExecutable(possible_ntputility, path);
> +    if (!ntpUtility.isEmpty()) {

nitpick again, feel free to fix or not before pushing: ntpUtility could be declared const

REPOSITORY
  R119 Plasma Desktop

BRANCH
  arcpatch-D26295

REVISION DETAIL
  https://phabricator.kde.org/D26295

To: meven, ervin, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20191231/f6dc8799/attachment.html>


More information about the Plasma-devel mailing list