D26312: [applets/digital-clock] Fix truncated Long Date display in a vertical panel

Nathaniel Graham noreply at phabricator.kde.org
Mon Dec 30 23:54:28 GMT 2019


ngraham created this revision.
ngraham added reviewers: Plasma, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  BUG: 381551
  FIXED-IN: 5.18.0

TEST PLAN
  Before: F7851382: Before.png <https://phabricator.kde.org/F7851382>
  
  After: F7851383: After.png <https://phabricator.kde.org/F7851383>
  
  Texted extensively because this code is so brittle. No regressions with long date in a
  thick or normal-sized horizontal panel or short date in a thick or normal-sized
  horizontal or vertical panel.
  
  The one issue I could find is that sometimes switching between short and long date
  formats in a double-thickness vertical panel causes the long date  to be truncated again
  until plasmashell is restarted. I was unable to determine why. Assistance would be
  appreciated if this is a blocker.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  fix-clock-long-date-in-vertical-panel (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26312

AFFECTED FILES
  applets/digital-clock/package/contents/ui/DigitalClock.qml

To: ngraham, #plasma, #vdg
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20191230/2bb49bc7/attachment.html>


More information about the Plasma-devel mailing list