D26295: [KCM/Datetime] Convert a foreach, port away from KStandardDirs

[Kevin Ottens]

ervin accepted this revision.
ervin added a comment.
This revision is now accepted and ready to land.


  Just a nitpick you can feel free to ignore, otherwise LGTM.

INLINE COMMENTS

> dtime.cpp:166
> +  for(const QString &possible_ntputility : possible_ntputilities) {
> +    if( !((ntpUtility = QStandardPaths::findExecutable(possible_ntputility, path_list)).isEmpty()) ) {
>        qDebug() << "ntpUtility = " << ntpUtility;

I'd use the opportunity to split that into two statements, I find the assign + test in if rather heavy to read.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26295

To: meven, ervin, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20191230/664c2108/attachment.html>