D26225: Change frameRadius to use pen widths, add newPenWidthFrameRadius, add PenWidth::NoPen

Hugo Pereira Da Costa noreply at phabricator.kde.org
Mon Dec 30 00:12:56 GMT 2019


hpereiradacosta accepted this revision.
hpereiradacosta added a comment.
This revision is now accepted and ready to land.


  In D26225#583803 <https://phabricator.kde.org/D26225#583803>, @ndavis wrote:
  
  > - Change newPenWidthFrameRadius to frameRadiusNewPenWidth
  >
  >   This sounds slightly better to me and allows it to show up next to frameRadius when autocompleting.
  
  
  What about "frameRadiusForPenWidth"  ? 
  I think the "New" is misleading. 
  If you agree, please change and then commit. The rest sounds good.

REPOSITORY
  R31 Breeze

BRANCH
  replace-hardcoded-2 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26225

To: ndavis, #breeze, #plasma, hpereiradacosta, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20191230/c5979580/attachment.html>


More information about the Plasma-devel mailing list