D26037: feat(kded): add orientation sensor

Roman Gilg noreply at phabricator.kde.org
Sun Dec 29 23:47:10 GMT 2019


romangg added inline comments.

INLINE COMMENTS

> davidedmundson wrote in orientation_sensor.h:38
> I suspect some apps will need that info, but it's just as easy for them to get that via QSensors directly.

Looking at it again I don't think it is advisable to remove these two values from the class interface. Instead having them in there for later and ignoring them in the meantime in the implementation in the KScreenDaemon is fine. See the comment there:

> We currently don't do anything with FaceUp/FaceDown, but in the future we could use them to shut off and switch on again a display when display is facing downwards/upwards.

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D26037

To: romangg, #plasma
Cc: plasma-devel, davidedmundson, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20191229/001a0f39/attachment.html>


More information about the Plasma-devel mailing list