D26279: ActionToolBar: Only show the overflow button if there are visible items in the menu

Arjen Hiemstra noreply at phabricator.kde.org
Sun Dec 29 19:26:53 GMT 2019


ahiemstra created this revision.
ahiemstra added a reviewer: Kirigami.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
ahiemstra requested review of this revision.

REVISION SUMMARY
  This fixes https://bugs.kde.org/show_bug.cgi?id=415412 , which was occuring because the
  overflow button did not properly check to see if the actions in the menu were actually
  visible.
  
  BUG: 415412

TEST PLAN
  The example code from the linked bug report now works correctly.

REPOSITORY
  R169 Kirigami

BRANCH
  actiontoolbar_contextbutton_visible

REVISION DETAIL
  https://phabricator.kde.org/D26279

AFFECTED FILES
  src/controls/ActionToolBar.qml

To: ahiemstra, #kirigami
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, ahiemstra, davidedmundson, mart, hein
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20191229/e83ddecb/attachment.html>


More information about the Plasma-devel mailing list