D26275: SourcesPage: Override contentItem of ListSectionHeader instead of relying on data property

[Arjen Hiemstra]

ahiemstra created this revision.
ahiemstra added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ahiemstra requested review of this revision.

REVISION SUMMARY
  Kirigami's ListSectionHeader has a default property that points to an embedded RowLayout's
  data property, in an attempt (I guess?) to make it simpler to add things to it. However,
  this does not work properly, at least not in combination with ActionToolBar. So instead,
  override the section header's contentItem so we can specify the right layout properties.
  
  BUG: 415666

TEST PLAN
  The sources page now displays actions properly, but still places them in the overflow menu
  when the window gets smaller.

REPOSITORY
  R134 Discover Software Store

BRANCH
  sources_actiontoolbar

REVISION DETAIL
  https://phabricator.kde.org/D26275

AFFECTED FILES
  discover/qml/SourcesPage.qml

To: ahiemstra, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20191229/17191ed5/attachment.html>