D26225: Add newFrameRadius, change frameRadius to use pen widths, add PenWidth::NoPen

Hugo Pereira Da Costa noreply at phabricator.kde.org
Fri Dec 27 22:42:10 GMT 2019


hpereiradacosta added inline comments.

INLINE COMMENTS

> breezehelper.h:318
> +        //* frame radius with new pen width
> +        constexpr qreal newFrameRadius ( const qreal oldRadius, const int penWidth ) const
> +        { return qMax( oldRadius - (0.5 * penWidth), 0.0 ); }

Would need a new function name than "newFrameRadius", that makes it clear when this should be used on not the other.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D26225

To: ndavis, #breeze, #plasma, hpereiradacosta, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20191227/302b2c9f/attachment-0001.html>


More information about the Plasma-devel mailing list