D26212: [Applet] Remember devices to raise maximum volume

Nathaniel Graham noreply at phabricator.kde.org
Thu Dec 26 20:01:57 GMT 2019


ngraham added a comment.


  Nice work.

INLINE COMMENTS

> StreamListItem.qml:29
>      property bool onlyOne: false
> +    readonly property string maxVolumeTarget: if (Client) {return Client.name}
>  

Could be simplified and hardened to `Client ? Client.name : ""`

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D26212

To: gvgeo, #plasma, drosca
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20191226/23d3d90a/attachment.html>


More information about the Plasma-devel mailing list