D26068: [KCM/Activity] Use KConfigXT to store settings

[Kevin Ottens]

ervin accepted this revision.
ervin added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> PrivacyTab.cpp:50
>  public:
> -    KSharedConfig::Ptr mainConfig;
> -    KSharedConfig::Ptr pluginConfig;
> +    KActivityManagerdSettings mainConfig;
> +    KActivityManagerdPluginsSettings pluginConfig;

I'd have it by pointer and give it a parent at construction time. It's a more common pattern for QObject as members.

> PrivacyTab.cpp:51
> +    KActivityManagerdSettings mainConfig;
> +    KActivityManagerdPluginsSettings pluginConfig;
>  

Ditto

REPOSITORY
  R119 Plasma Desktop

BRANCH
  activity_kcm

REVISION DETAIL
  https://phabricator.kde.org/D26068

To: meven, #plasma, ervin, crossi
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20191223/b745d5cc/attachment.html>