D24846: Port kcm icons to kconfigxt

[Kevin Ottens]

ervin added a comment.


  Just a couple of stylistic issues left AFAICT

INLINE COMMENTS

> iconsmodel.h:47
>  public:
> -    IconsModel(QObject *parent);
> +    IconsModel(QObject *parent, IconsSettings *iconsSettings);
>      ~IconsModel() override;

Kind of a nitpick in this context, but parent should go last and default to nullptr. It's the Qt convention for QObject ctors.

> iconssettings.cpp:48
> +    if (m_themeDirty)
> +    {
> +        KIconTheme::reconfigure();

The opening curly braces should be on the same line than the if

> main.cpp:135
>      m_model->load();
> -    loadIconSizes();
> -    m_model->setSelectedTheme(KIconTheme::current());
> -    setNeedsSave(false);
> -    m_selectedThemeDirty = false;
> -    m_iconSizesDirty = false;
> +    emit m_settings->ThemeChanged();
>  }

This one likely requires a comment, since normally you wouldn't need such an emit.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24846

To: bport, ervin, mart, #plasma, crossi
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20191223/b89fd671/attachment.html>