D26121: Kicker/RecentDocument display file path as decoration

Méven Car noreply at phabricator.kde.org
Fri Dec 20 21:14:19 GMT 2019


meven marked an inline comment as done.
meven added inline comments.

INLINE COMMENTS

> ngraham wrote in recentusagemodel.cpp:365
> Probably worth just doing this in a single line rather than defining a variable used only once

I did this for readability, I think we should keep this.
The alternative is a little convoluted :

  KIO::highlightInFileManager({QUrl::fromUserInput(resourceAt(row))});

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26121

To: meven, #vdg, #plasma, ngraham, ervin
Cc: davidre, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20191220/3118c7d2/attachment-0001.html>


More information about the Plasma-devel mailing list