D26120: [Wizard] Show notification instead of finished page when pairing succeeds
Kai Uwe Broulik
noreply at phabricator.kde.org
Fri Dec 20 11:09:40 GMT 2019
broulik created this revision.
broulik added reviewers: VDG, drosca, Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.
REVISION SUMMARY
Saves the user from having to close the dialog when pairing succeeded.
TEST PLAN
- Not too happy about this approach, but `done` is `protected`, just closing the dialog from the page doesn't properly dismiss it. Maybe I should add a signal on the page instead?
F7826564: Screenshot_20191220_120611.png <https://phabricator.kde.org/F7826564>
REPOSITORY
R97 Bluedevil
REVISION DETAIL
https://phabricator.kde.org/D26120
AFFECTED FILES
src/bluedevil.notifyrc
src/wizard/CMakeLists.txt
src/wizard/bluewizard.cpp
src/wizard/pages/success.cpp
To: broulik, #vdg, drosca, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20191220/1f5d3874/attachment.html>
More information about the Plasma-devel
mailing list