D25851: [Notifications] Add quick reply feature

Kai Uwe Broulik noreply at phabricator.kde.org
Thu Dec 19 14:33:51 GMT 2019


broulik added inline comments.

INLINE COMMENTS

> notification.cpp:637
>  
> +        if (!d->hasReplyAction && name == QLatin1String("reply")) {
> +            d->hasReplyAction = true;

I'll change that to "inline-reply" to avoid potential clashes

> server_p.cpp:234
>          QStringLiteral("actions"),
> +        QStringLiteral("reply-action"),
>  

Will rename to "inline-reply"

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D25851

To: broulik, #plasma, #vdg
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20191219/4ed82ddd/attachment.html>


More information about the Plasma-devel mailing list