D26093: Use a fixed icon size for the notification popup close button

[Arjen Hiemstra]

ahiemstra created this revision.
ahiemstra added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ahiemstra requested review of this revision.

REVISION SUMMARY
  Both the popup header size as well as units.smallMargin depend on font
  size. This causes problems with the new circular timeout indicator.
  Rather than trying to somehow fix the margins, this patch changes things
  to use units.iconSizes.smallMedium as close button icon size instead,
  stopping it from relying on font size and hopefully fixing any layout
  issues.

TEST PLAN
  Change font size to 10/11/12 pt. Icon size remains the same.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  notification_close_size

REVISION DETAIL
  https://phabricator.kde.org/D26093

AFFECTED FILES
  applets/notifications/package/contents/ui/NotificationHeader.qml

To: ahiemstra, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20191218/24b78fbb/attachment-0001.html>