D26088: [XembedSNIProxy] Regression - really resize instead of notifying only.

[Konrad Materka]

kmaterka added inline comments.

INLINE COMMENTS

> sniproxy.cpp:228
>  {
> -    xcb_configure_notify_event_t event;
> -    memset(&event, 0x00, sizeof(xcb_configure_notify_event_t));

xcb_configure_notify_event_t

@davidedmundson In this commit <https://github.com/KDE/plasma-workspace/commit/1a13806d74973137960e64aa347965525a7c626a> you added xcb_configure_notify_event_t to resize window. Do you remember why and which application were not working correctly? Seems that old review board os down.

> sniproxy.cpp:239
> +
> +    xcb_flush(connection);
>  }

xcb_flush is probably not needed, but better make sure is is handled before we capture image.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26088

To: kmaterka, #plasma_workspaces, #plasma, davidedmundson
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20191218/48bcdb5f/attachment.html>