D26039: [Plasma Style KCM] Add search filter

[Cyril Rossi]

crossi added a comment.


  Some concern here as I tested the patch. The filter is working but the implementation breaks some functionality.
  
  - At initialization, the current theme is not selected in the grid view.
  - When settings a theme for deletion, it does not activate the apply button and the theme is no longer greyed out in the grid view.

INLINE COMMENTS

> kcm.cpp:72
> +
> +    connect(m_model, &ThemesModel::pendingDeletionsChanged, this, [this] {
> +        setNeedsSave(true);

Should connect to KCMDesktopTheme::settingsChanged slot to request ManagedConfigModule to reassess isSaveNeeded().

> kcm.cpp:313
>  
> -bool KCMDesktopTheme::isSaveNeeded() const
> -{

Why removing this ?

It is necessary for ManagedConfigModule to enable the apply button when items are marked for deletion.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26039

To: davidre, #plasma, #vdg, broulik
Cc: ndavis, crossi, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20191217/e31d9051/attachment-0001.html>