D26042: Captive portal notification improvements

[David Edmundson]

davidedmundson added a comment.


  Due to a confusing design notification objects can delete themselves.
  
  If the network changes after the notification is externally closed this will crash.

INLINE COMMENTS

> portalmonitor.h:42
> +private:
> +    KNotification *m_notification = nullptr;
>  };

Needs to be QPointer

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D26042

To: jgrulich, ngraham, broulik, #plasma
Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20191217/dc9994a1/attachment.html>