D26045: Add immutability to KCM Icons

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> main.qml:38
>      view.currentIndex: kcm.pluginIndex(kcm.iconsSettings.theme)
> -    enabled: !kcm.downloadingFile
>  

Why this change?

> main.qml:55
>  
> +        enabled: !kcm.iconsSettings.isImmutable("Theme") // don't allow to change theme if immutable, but allow to change icon sizes
> +

Shouldn't this be set on the grid view then, i.e. the `view.enabled` stuff Marco fixed a while back?

> main.qml:230
>              QtControls.Button {
> +                enabled: true
>                  id: iconSizesButton

This is the default

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26045

To: bport, #plasma, ervin, ngraham, crossi, meven
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20191217/f43fc4e5/attachment-0001.html>