[Breeze] [Bug 364953] Breeze and Breeze Light themes are the same but listed twice

Filip Fila bugzilla_noreply at kde.org
Sun Dec 15 21:12:23 GMT 2019


https://bugs.kde.org/show_bug.cgi?id=364953

Filip Fila <filipfila.kde at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Latest Commit|                            |https://commits.kde.org/pla
                   |                            |sma-desktop/3245c6bc9b7719c
                   |                            |5fdad17ac70c49c12a102d75a
             Status|CONFIRMED                   |RESOLVED
         Resolution|---                         |FIXED

--- Comment #6 from Filip Fila <filipfila.kde at gmail.com> ---
Git commit 3245c6bc9b7719c5fdad17ac70c49c12a102d75a by Filip Fila.
Committed on 15/12/2019 at 21:12.
Pushed by filipf into branch 'master'.

[Plasma Style KCM] Add a color-wheel sign denoting the theme supports the
system color scheme

Summary:
The discoverability of the system color scheme awareness feature of some Plasma
themes right now is very poor.

In addition to that the previews for Breeze and Breeze Light look identical
when using the default color scheme.

To fix this we add a little color wheel icon in the top right corner of the
theme preview that only shows up if the theme supports this.

Credits go to @broulik for most of the code, I just positioned the icon.

Test Plan:
Depends on: D25999

{F7818015}

Doesn't get messed up with scaling either.

Reviewers: #plasma, #vdg, ngraham

Reviewed By: #vdg, ngraham

Subscribers: ngraham, broulik, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D25785

M  +4    -0    kcms/desktoptheme/kcm.cpp
M  +1    -0    kcms/desktoptheme/kcm.h
M  +11   -5    kcms/desktoptheme/package/contents/ui/ThemePreview.qml
M  +1    -0    kcms/desktoptheme/package/contents/ui/main.qml

https://commits.kde.org/plasma-desktop/3245c6bc9b7719c5fdad17ac70c49c12a102d75a

-- 
You are receiving this mail because:
You are the assignee for the bug.


More information about the Plasma-devel mailing list