D25945: Sync dark theme preference for GTK3 applications

[Mikhail Zolotukhin]

gikari created this revision.
gikari added reviewers: apol, cblack, broulik.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
gikari requested review of this revision.

REVISION SUMMARY
  Previously preference of dark GTK3 theme was set by checkbox in GTK KCM.  Now, the checkbox is removed and preference is set according to color scheme, the user set in Colors KCMm, using the same heuristic, used for filter combobox in that KCM.
  
  This makes sense, because, suppose the user set Adwaita GTK3 theme, and their color scheme is something dark. Therefore their overall theme is supposedly dark, so Adwaita needs to be dark too.
  
  Note, however, that this preference is somewhat buggy. It does not work in flatpak apps, it can't be autoreloaded with xsettingsd, and also it is applied after some time has passed (this is hypothetical). You can check these statements, using the present checkbox in GTK KCM.
  
  Depends on D25872 <https://phabricator.kde.org/D25872>

TEST PLAN
  1. Apply Adwaita GTK3 Theme
  2. Reload kded5
  3. Apply dark color scheme
  4. Wait some time
  5. (Re)open GTK3 app
  6. App should use Dark color scheme
  7. Apply light color scheme
  8. Wait some time
  9. Reopen GTK3 app
  10. App should use Light color scheme

REPOSITORY
  R99 KDE Gtk Configuration Tool

BRANCH
  sync-dark-gtk3-theme-preference (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25945

AFFECTED FILES
  CMakeLists.txt
  kded/configvalueprovider.cpp
  kded/configvalueprovider.h
  kded/gtkconfig.cpp
  kded/gtkconfig.h
  src/appearancegtk3.cpp
  src/appearancegtk3.h
  src/appearencegtk.cpp
  src/appearencegtk.h
  src/gtkconfigkcmodule.cpp
  src/ui/gui.ui
  tests/configsavetest.cpp

To: gikari, apol, cblack, broulik
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20191213/3e4b807f/attachment.html>