D25942: Instead of just delaying, compress calls to update

[Marco Martin]

mart added inline comments.

INLINE COMMENTS

> ActionToolBarLayoutDetails.qml:106
> +        id: delayUpdate
> +        interval: 200
> +        onTriggered: update()

i suppose if the delay is 0 it starts to jump again?

> broulik wrote in ActionToolBarLayoutDetails.qml:110
> How can this even work? `start` is a method. You probably meant `running = true`? or `start()` which, in contrast to a `QTimer` will *not* restart the timer if already running.
> 
> So apparently this isn't necessary at all, if it not doing anything actually works?

to properly do event compression, you should do timer.restart()
(which, if already running restart the timer from 0)

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D25942

To: apol, #kirigami
Cc: mart, ngraham, broulik, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, apol, ahiemstra, davidedmundson, hein
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20191213/fcf3dd13/attachment.html>