D25942: Instead of just delaying, compress calls to update

Kai Uwe Broulik noreply at phabricator.kde.org
Fri Dec 13 09:59:40 GMT 2019


broulik added inline comments.

INLINE COMMENTS

> ActionToolBarLayoutDetails.qml:110
> +
> +    onWidthChanged: { delayUpdate.start = true }
> +    Component.onCompleted: { delayUpdate.start = true }

How can this even work? `start` is a method. You probably meant `running = true`? or `start()` which, in contrast to a `QTimer` will *not* restart the timer if already running.

So apparently this isn't necessary at all, if it not doing anything actually works?

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D25942

To: apol, #kirigami
Cc: broulik, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, ahiemstra, davidedmundson, mart, hein
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20191213/58b118f6/attachment.html>


More information about the Plasma-devel mailing list