D25923: [KCMs/Night Color] Remove "manual location entry" mode

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: VDG, Plasma, davidedmundson.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  This mode allows you to set Night Color to trigger based on the sunset/sunrise times of an
  arbitrary latitude/longitude location. However this is completely pointless; there is no
  conceivable use case for setting the location to any place other than your current
  location. The only reason why you would want to enter your current location manually is
  if the automatic geolocation feature is broken. However if this is the case, it is much
  faster to just enter start/end times manually than it is to look up your latitude and
  longitude and enter them into the text fields here.
  
  Therefore, this patch removes that mode from the KCM and requires that people who don't
  use the automatic geolocation feature enter the start/end times manually.
  
  In the future, we could even remove the geolocator and base the location on the current
  time zone so we can bypass failures of the geolocator.

TEST PLAN
  Modes now: F7814125 <https://phabricator.kde.org/F7814125>

REPOSITORY
  R119 Plasma Desktop

BRANCH
  remove-manual-location-entry-mode (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25923

AFFECTED FILES
  kcms/nightcolor/package/contents/ui/LocationsFixedView.qml
  kcms/nightcolor/package/contents/ui/main.qml

To: ngraham, #vdg, #plasma, davidedmundson
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20191212/168fd88a/attachment-0001.html>