D25884: Find qdbus command correctly

Nathaniel Graham noreply at phabricator.kde.org
Wed Dec 11 13:30:22 GMT 2019


ngraham created this revision.
ngraham added reviewers: davidedmundson, fvogt, Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  The wallpeper knsrc file file assumes that `qdbus` is in $PATH. However this is not
  guaranteed; the command lives in the Qt binaries dir which is not typically in $PATH,
  and distros typically create symlinks with different names in `/usr/bin`, but not all
  create a second compatibility symlink at `/usr/bin/qdbus` that points to the version
  for the current Qt version.
  
  Therefore, we should find the command in the Qt binaries dir itself rather than relying
  on these compatibility symlinks.

TEST PLAN
  See that the knsrc file now has the absolute path to `qdbus` in it

REPOSITORY
  R120 Plasma Workspace

BRANCH
  find-qdbus-correctly (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25884

AFFECTED FILES
  CMakeLists.txt
  wallpapers/image/CMakeLists.txt
  wallpapers/image/wallpaper.knsrc
  wallpapers/image/wallpaper.knsrc.cmake

To: ngraham, davidedmundson, fvogt, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20191211/84e937a6/attachment.html>


More information about the Plasma-devel mailing list