D25882: Remove dynamic item creation in DefaultListItemBackground

[Arjen Hiemstra]

ahiemstra created this revision.
ahiemstra added a reviewer: Kirigami.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
ahiemstra requested review of this revision.

REVISION SUMMARY
  For some unknown reason, DefaultListItemBackground uses dynamic item creation
  instead of just declaring items for its separators. This patch removes the
  dynamic item creation and just declares the separtor. This saves more than
  1ms runtime per delegate that gets created in Kirigami Gallery's List View page,
  reducing the time per delegate from more than 1ms to ~300us.

TEST PLAN
  Kirigami Gallery's List View page still looks the same

REPOSITORY
  R169 Kirigami

BRANCH
  remove_dynamicitem

REVISION DETAIL
  https://phabricator.kde.org/D25882

AFFECTED FILES
  src/controls/private/DefaultListItemBackground.qml

To: ahiemstra, #kirigami
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, ahiemstra, davidedmundson, mart, hein
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20191211/a12828ad/attachment.html>